Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Relay] Check function attr for hash #4479

Merged
merged 1 commit into from
Dec 8, 2019
Merged

[Relay] Check function attr for hash #4479

merged 1 commit into from
Dec 8, 2019

Conversation

zhiics
Copy link
Member

@zhiics zhiics commented Dec 7, 2019 •
edited
Loading

This PR adds function attrs for hash.

@jroesch @icemelon9 @wweic @MarisaKirisame

MarisaKirisame
MarisaKirisame reviewed Dec 7, 2019
View reviewed changes
Copy link
Contributor

@MarisaKirisame MarisaKirisame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just a check, alpha equal already check attr, and hash doesnt (the title is misnamed, it should be for hash), right?

@zhiics zhiics changed the title [Relay] Check function attr for alpha equal [Relay] Check function attr for hash Dec 7, 2019
@zhiics
Copy link
Member Author

zhiics commented Dec 7, 2019

@MarisaKirisame Yes, you are right. Just changed the title.

@tqchen tqchen merged commit 5fe5cee into apache:master Dec 8, 2019
@zhiics zhiics deleted the func_attr branch December 8, 2019 21:38
zxy844288792 pushed a commit to zxy844288792/tvm that referenced this pull request Dec 13, 2019
@zhiics
Check function attr for alpha equal (apache#4479)
626c39c
zxy844288792 pushed a commit to neo-ai/tvm that referenced this pull request Dec 13, 2019
@zhiics
Check function attr for alpha equal (apache#4479)
76f741f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarisaKirisame MarisaKirisame MarisaKirisame left review comments

@wweic wweic wweic approved these changes

@tqchen tqchen tqchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zhiics @wweic @tqchen @MarisaKirisame